fix(hpb-service): Support HPB service accounts without expiration #15698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancycode
changed the title
nickvergessen
approved these changes
Aug 26, 2025
nickvergessen
added
feature: settings ⚙️
Member
|
Rebasing to see if it fixes CI |
…pire. Signed-off-by: Joachim Bauch <[email protected]>
Signed-off-by: Joachim Bauch <[email protected]>
nickvergessen
force-pushed
the
fix/hpbservice
branch
from
527e6c1 to
dffd100
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While not very common, there are HPB service accounts without an expiration date, this should be supported in the UI. This introduces a new string for translation.
Also the nonce for HPB request authentication was only cleared in successful cases, this should also be done if a request failed. Without this I see occasional errors about
nonce_mismatchin the log.